Skip to content

Not suggest terrascan#744

Merged
TylerJang27 merged 2 commits intotrunk-io:mainfrom
yu-iskw:patch-1
Apr 23, 2024
Merged

Not suggest terrascan#744
TylerJang27 merged 2 commits intotrunk-io:mainfrom
yu-iskw:patch-1

Conversation

@yu-iskw
Copy link
Copy Markdown
Contributor

@yu-iskw yu-iskw commented Apr 15, 2024

terrascan is no longer actively maintained. So, it would be good not to suggest even if related files exist.

terrascan is no longer actively maintained. So, it would be good not to suggest if related files exist.
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 15, 2024

⏱️ 11m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Linter Tests 3m 🟩
Linter Tests ubuntu-latest 3m 🟩
Linter Tests macOS 2m 🟩
Trunk Check runner [linux] 1m 🟩
CodeQL-Build 1m 🟩
Repo Tests / Plugin Tests 37s 🟥
Detect changed files 5s 🟩
Aggregate Test Results 1s 🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

@yu-iskw yu-iskw marked this pull request as ready for review April 15, 2024 12:00
@TylerJang27
Copy link
Copy Markdown
Collaborator

TylerJang27 commented Apr 15, 2024

Hi @yu-iskw! Thanks for flagging this: I'll discuss with the team if we want to go ahead and turn this off by default for everyone. A couple questions:

  • What made you say it's no longer maintained? It looks like their last release was in March (although I do see the substantial backlog of issues)
  • Were you encountering a lot of linter failures when running terrascan in your repo? If so, could you include the failure outputs? It's possible we can modify our integration to improve the failure rate.

@yu-iskw
Copy link
Copy Markdown
Contributor Author

yu-iskw commented Apr 16, 2024

According to the commit stats of terrascan, I don't think it is actively developed.

image

For instance, terrascan doesn't support newer versions of terraform. For instance, it doesn't support the import block. I encountered violations caused by the less active maintenance. So, I decided not to use terrascan.

tenable/terrascan#1590

@TylerJang27
Copy link
Copy Markdown
Collaborator

I talked this one over with the team, and we agreed to disable it for now. Thanks for the PR!

@TylerJang27 TylerJang27 merged commit 3fe6dc6 into trunk-io:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants