Not suggest terrascan#744
Merged
TylerJang27 merged 2 commits intotrunk-io:mainfrom Apr 23, 2024
Merged
Conversation
terrascan is no longer actively maintained. So, it would be good not to suggest if related files exist.
⏱️ 11m total CI duration on this PR
|
Collaborator
|
Hi @yu-iskw! Thanks for flagging this: I'll discuss with the team if we want to go ahead and turn this off by default for everyone. A couple questions:
|
Contributor
Author
|
According to the commit stats of terrascan, I don't think it is actively developed. For instance, terrascan doesn't support newer versions of terraform. For instance, it doesn't support the |
Collaborator
|
I talked this one over with the team, and we agreed to disable it for now. Thanks for the PR! |
TylerJang27
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

terrascan is no longer actively maintained. So, it would be good not to suggest even if related files exist.